Skip to content

Minor optype tidiness: unused Duration import; DaprPort admits 0 #37

Description

@sideeffffect

Severity: low · Category: tidiness

Evidence

  • src/optypes/DaprDuration.scala:3 — imports {FiniteDuration, Duration} but only FiniteDuration is referenced (dead import).
  • src/optypes/DaprPort.scala:13 — accepts 0 (n >= 0 && n <= 65535); the doc says "0–65535" so code/doc agree, but 0 is not a connectable sidecar port.

Suggested fix
Drop the unused Duration import. Optionally tighten DaprPort to 1–65535 if an ephemeral port is never bound via this type. (CloudEventSpecVersion's non-empty-only validation is correct for a forward-compatible inbound field — leave it.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    lowLow importance

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions