Skip to content

TARC-360 SIFO ignores some Smarty errors in debug mode #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xserrat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TARC-360 SIFO ignores some Smarty errors in debug mode #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/Sifo/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@

namespace Sifo;

use function trigger_error;
use const E_USER_WARNING;

/**
* Templating engine. Compiles some smarty stuff for an easier management.
*/
Expand Down Expand Up @@ -98,18 +101,23 @@ private function setTwigTemplatingEngine()

public static function customErrorHandler($errno, $errstr, $errfile, $errline)
{
$error_has_been_silented = (0 === error_reporting());
if ($error_has_been_silented)
{
return false;
}

$error_friendly = Debug::friendlyErrorType($errno);
$error_string = "[{$error_friendly}] {$errstr} in {$errfile}:{$errline}";

if (Domains::getInstance()->getDebugMode())
{
Debug::subSet('smarty_errors', $errfile, '<pre>' . $error_string . '</pre>', true);
$error_message = $error_string;
if (!empty(Urls::$actual_url)) {
$error_message .= ' in URL: ' . Urls::$actual_url;
}
trigger_error($error_message, E_USER_WARNING);
}

$error_has_been_silented = (0 === error_reporting());
if ($error_has_been_silented)
{
return false;
}

// Smarty only write PHP USER errors to log:
Expand Down