Skip to content

PYR1-1199 add clj-watson #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhvs merged 2 commits into from
Oct 9, 2025
Merged

PYR1-1199 add clj-watson #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc6005e
add clj-watson alias
Oct 7, 2025
b844b76
add command to the readme in a new section as per PR review
Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,9 @@ See [[file:API.md][API.md]]
** Docs
To generate docs, use: ~bb docs~

** Vulerability checking
To check for vulerabilities in this project, use ~clojure -M:clj-watson scan -p deps.edn -s~

** License

Copyright © 2021-2025 Spatial Informatics Group, LLC.
Expand Down
6 changes: 5 additions & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,8 @@
:sha "7284cda41fb9edc0f3bc6b6185cfb7138fc8a023"}}
:main-opts ["-e" "(do,(set!,*warn-on-reflection*,true),nil)"
"-m" "cognitect.test-runner"
"--include" ":db"]}}}
"--include" ":db"]}
:clj-watson {:replace-deps

@drewverlee drewverlee Oct 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what deps is this replacing? I think, despite the quickstart instructions, so i would consider testing :extra-deps.

Also, consider moving the command to run it, along with other sig specific instructions, to the readme under a new section about vulnerability detection (or whatever title resonates!)

Thanks!

@sifbiri sifbiri Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think clj-watson doesn't need deps loaded.

@danielhvs danielhvs Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clj-watson seems to read the deps.edn file "by hand":
https://github.com/clj-holmes/clj-watson/blob/main/src/clj_watson/controller/deps.clj#L41

{io.github.clj-holmes/clj-watson
{:git/tag "v6.0.1" :git/sha "b520351"}}
:main-opts ["-m" "clj-watson.cli"]}}}