TRIAN-115: Allow JAR builds without config.edn - #152
Merged
Merged
Conversation
drewverlee
reviewed
Oct 10, 2025
|
|
||
| (def development-app | ||
| (defonce ^:private handler | ||
| (delay (create-handler-stack |
Contributor
There was a problem hiding this comment.
I believe this will work, but why use a delay instead of turning the handler into a function? (to be fair I think i used delay in a couple spots where a function would have been simpler too!)
Collaborator
Author
There was a problem hiding this comment.
so we can have it run at runtime once.
Contributor
|
This and the accompanying Pyregence changes look good, assuming the testing worked out, hopefully we can merge this soon! Thanks sif! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Defer handler creation and config.edn loading to runtime
Related Issues
Closes TRIAN-115
Test
clojure -X:build-uberjarwithout config.edn should work.