fix: resolve spawn EINVAL on Windows for .cmd Pi binary - #3
Open
alexliu072903-bit wants to merge 1 commit into
Open
alexliu072903-bit wants to merge 1 commit into
alexliu072903-bit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
child_process.spawn()cannot directly execute.cmdfiles withoutshell: true. When the Pi binary path points topi.cmd(the standard npm global install on Windows), the plugin throws:This makes the plugin completely non-functional on Windows out of the box.
Fix
Add
shell: process.platform === "win32"to the spawn options insrc/rpc.ts:This is platform-gated so it only applies on Windows and has no effect on macOS/Linux.
Tested on
C:\Users\<user>\AppData\Roaming\npm\pi.cmdRelated
Discovered while building obsidian-ai-starter, a setup guide for Pi + Obsidian on Windows.