Add mod_sofia DIV PASSporT integration for libstirshaken#3014
Open
thehunmonkgroup wants to merge 1 commit into
Open
Add mod_sofia DIV PASSporT integration for libstirshaken#3014thehunmonkgroup wants to merge 1 commit into
thehunmonkgroup wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This integrates DIV PASSporT support into
mod_sofiafor single-diversion STIR/SHAKEN flows for libstirshaken.Outbound INVITEs can now generate a DIV PASSporT Identity header from an existing SHAKEN Identity header when
sip_stir_shaken_div=trueis set. The DIV signing path supports profile defaults and channel overrides for the DIVx5u, destination, original destination selection,reason, andhi.Inbound verification now understands supported Identity header sets containing SHAKEN and DIV PASSporTs, verifies the SHAKEN/DIV chain together, validates DIV destination claims against the SIP request target, and preserves the existing
sip_verstatbehavior for successful or failed validation.Configuration
Adds
mod_sofiaprofile defaults for DIV signing:stir-shaken-div-as-urlstir-shaken-div-reasonstir-shaken-div-hiAlso documents the related channel variables in the sample Sofia config.
Tests
Adds Sofia tests covering DIV Identity generation from
sip_h_identityor an explicit SHAKEN Identity, fail-closed behavior for missing/invalid DIV inputs, valid SHAKEN/DIV chain verification, and destination mismatch rejection.Modernizes the test certificate server wrapper to work with Python 3.
Dependency
This depends on the pending libstirshaken DIV PASSporT API changes in:
signalwire/libstirshaken#143