feat: adding telemetry-trace-sample-rate cli arg and set default to 1%

beacon_node/client/src/config.rs

@@ -79,6 +79,7 @@ pub struct Config {
     pub genesis_state_url: Option<String>,
     pub genesis_state_url_timeout: Duration,
     pub allow_insecure_genesis_sync: bool,
+    pub telemetry_sample_ratio: Option<f64> // for testing only
 }
 
 impl Default for Config {
@@ -107,6 +108,7 @@ impl Default for Config {
             // This default value should always be overwritten by the CLI default value.
             genesis_state_url_timeout: Duration::from_secs(60),
             allow_insecure_genesis_sync: false,
+            telemetry_sample_ratio: None
         }
     }
 }

book/src/help_bn.md

@@ -399,6 +399,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
       --trusted-peers <TRUSTED_PEERS>
           One or more comma-delimited trusted peer ids which always have the
           highest score according to the peer scoring system.

book/src/help_general.md

@@ -83,6 +83,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
   -V, --version
           Print version
 

book/src/help_vc.md

@@ -141,6 +141,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
       --validator-registration-batch-size <INTEGER>
           Defines the number of validators per validator/register_validator
           request sent to the BN. This value can be reduced to avoid timeouts

book/src/help_vm.md

@@ -84,6 +84,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
 
 Flags:
       --disable-log-timestamp

book/src/help_vm_create.md

@@ -100,6 +100,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
 
 Flags:
       --disable-deposits

book/src/help_vm_import.md

@@ -80,6 +80,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
       --validators-file <PATH_TO_JSON_FILE>
           The path to a JSON file containing a list of validators to be imported
           to the validator client. This file is usually named "validators.json".

book/src/help_vm_move.md

@@ -89,6 +89,12 @@ Options:
           Override the OpenTelemetry service name. Defaults to 'lighthouse-bn'
           for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse'
           for other subcommands.
+      --telemetry-trace-sample-rate <PERCENT>
+          OpenTelemetry trace sampling rate as a percentage (0-100). A value of
+          1 means 1% of traces are sampled. Lower values reduce resource
+          consumption. For more info see
+          https://opentelemetry.io/docs/concepts/sampling/#why-sampling
+          [default: 1]
       --validators <STRING>
           The validators to be moved. Either a list of 0x-prefixed validator
           pubkeys or the keyword "all".

lighthouse/Cargo.toml

@@ -61,6 +61,7 @@ network_utils = { workspace = true }
 opentelemetry = { workspace = true }
 opentelemetry-otlp = { workspace = true }
 opentelemetry_sdk = { workspace = true }
+mockall = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 serde_yaml = { workspace = true }

lighthouse/src/main.rs

@@ -294,6 +294,23 @@ fn main() {
                 .global(true)
                 .display_order(0)
         )
+        .arg(
+            Arg::new("telemetry-trace-sample-rate")
+                .long("telemetry-trace-sample-rate")
+                .value_name("PERCENT")
+                .help(
+                    "OpenTelemetry trace sampling rate as a percentage (0-100). \
+                    A value of 1 means 1% of traces are sampled. \
+                    Lower values reduce resource consumption. \
+                    For more info see https://opentelemetry.io/docs/concepts/sampling/#why-sampling"
+                )
+                .requires("telemetry-collector-url")
+                .value_parser(clap::value_parser!(u8).range(0..=100))
+                .default_value("1")
+                .action(ArgAction::Set)
+                .global(true)
+                .display_order(0)
+        )
         .arg(
             Arg::new("datadir")
                 .long("datadir")
@@ -657,6 +674,7 @@ fn run<E: EthSpec>(
         .eth2_network_config(eth2_network_config)?
         .build()?;
 
+    let mut telemetry_sample_ratio = None;
     if let Some(telemetry_collector_url) = matches.get_one::<String>("telemetry-collector-url") {
         let telemetry_layer = environment.runtime().block_on(async {
             let exporter = opentelemetry_otlp::SpanExporter::builder()
@@ -675,8 +693,18 @@ fn run<E: EthSpec>(
                     _ => "lighthouse".to_string(),
                 });
 
+            // Calculate sample percent as a ratio (percentage / 100)
+            telemetry_sample_ratio = Some(matches
+                .get_one::<u8>("telemetry-trace-sample-rate")
+                .copied()
+                .unwrap_or(1) as f64 / 100.0);
+            let sampler = opentelemetry_sdk::trace::Sampler::ParentBased(Box::new(
+                opentelemetry_sdk::trace::Sampler::TraceIdRatioBased(telemetry_sample_ratio.unwrap()),
+            ));
+
             let provider = opentelemetry_sdk::trace::SdkTracerProvider::builder()
                 .with_batch_exporter(exporter)
+                .with_sampler(sampler)
                 .with_resource(
                     opentelemetry_sdk::Resource::builder()
                         .with_service_name(service_name)
@@ -823,6 +851,7 @@ fn run<E: EthSpec>(
             let executor = context.executor.clone();
             let mut config = beacon_node::get_config::<E>(matches, &context)?;
             config.logger_config = logger_config;
+            config.telemetry_sample_ratio = telemetry_sample_ratio;
             // Dump configs if `dump-config` or `dump-chain-config` flags are set
             clap_utils::check_dump_configs::<_, E>(matches, &config, &context.eth2_config.spec)?;
 
@@ -868,4 +897,4 @@ fn run<E: EthSpec>(
         ShutdownReason::Success(_) => Ok(()),
         ShutdownReason::Failure(msg) => Err(msg.to_string()),
     }
-}
+}

lighthouse/tests/beacon_node.rs

@@ -2839,3 +2839,42 @@ fn invalid_block_roots_default_mainnet() {
             assert!(config.chain.invalid_block_roots.is_empty());
         })
 }
+
+#[test]
+fn telemetry_sample_rate_default() {
+    let float_tolerance: f64 = 1e-3;
+    let expected_ratio = 0.01;
+
+    CommandLineTest::new()
+        .flag("telemetry-collector-url", Some("http://localhost:4317"))
+        .run_with_zero_port()
+        .with_config(|config| {
+            let actual_ratio = config.telemetry_sample_ratio.expect("telemetry_sample_ratio should be set");
+            assert!(
+                (actual_ratio - expected_ratio).abs() < float_tolerance,
+                "Expected {}, got {}",
+                expected_ratio,
+                actual_ratio
+            );
+        });
+}
+
+#[test]
+fn telemetry_sample_rate_custom() {
+    let float_tolerance: f64 = 1e-3;
+    let expected_ratio = 0.05;
+
+    CommandLineTest::new()
+        .flag("telemetry-trace-sample-rate", Some("5"))
+        .flag("telemetry-collector-url", Some("http://localhost:4317"))
+        .run_with_zero_port()
+        .with_config(|config| {
+            let actual_ratio = config.telemetry_sample_ratio.expect("telemetry_sample_ratio should be set");
+            assert!(
+                (actual_ratio - expected_ratio).abs() < float_tolerance,
+                "Expected {}, got {}",
+                expected_ratio,
+                actual_ratio
+            );
+        });
+}