Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Dec 17, 2025

This PR speeds up the biblical terms tab by only querying the realtime server for biblical terms matching the current book.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.82%. Comparing base (b4c0ae8) to head (5aa09ff).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pture/ClientApp/src/app/core/sf-project.service.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3616      +/-   ##
==========================================
- Coverage   82.82%   82.82%   -0.01%     
==========================================
  Files         610      610              
  Lines       37400    37414      +14     
  Branches     6127     6152      +25     
==========================================
+ Hits        30976    30987      +11     
+ Misses       5491     5481      -10     
- Partials      933      946      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this Dec 22, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice a significant increase in loading biblical terms, but my projects did not have a large number of notes. The logic looks good to me.

@RaymondLuong3 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Dec 22, 2025
@RaymondLuong3 RaymondLuong3 merged commit 0796248 into master Jan 2, 2026
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3670 branch January 2, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants