Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Updates to be compatible with Mint 21.3#25

Open
mdepa wants to merge 5 commits intosimonmicro:masterfrom
mdepa:dev
Open

Updates to be compatible with Mint 21.3#25
mdepa wants to merge 5 commits intosimonmicro:masterfrom
mdepa:dev

Conversation

@mdepa
Copy link
Copy Markdown

@mdepa mdepa commented Jan 21, 2024

Mint 21.3 upgraded Cinnamon to use Soup 3 as backend messaging layer.

Updated applet to correctly use such new version in addition to the well known Soup 2 lib.

@mdepa mdepa closed this Jan 21, 2024
@mdepa mdepa reopened this Jan 21, 2024
@mdepa
Copy link
Copy Markdown
Author

mdepa commented Jan 21, 2024

I mistakenly created a PR from the fork targeting the main repo: sorry for the issue I really don't want to dirt the original applet.

@simonmicro
Copy link
Copy Markdown
Owner

simonmicro commented Jan 25, 2024

Heyho, your changes are always welcome 😁 - may I ask what the binary blob should be? I assume it is a picture, but then you should not just add it to the repository (especially if you are not the creator and have the correct license).

@mdepa
Copy link
Copy Markdown
Author

mdepa commented Jan 27, 2024

Hi,

this change was really not meant to get included into main repo: github by default creates merge requests toward original repo in place of forked one and I didn't notice it at first, sorry for the inconvenience.

Anywaym I think you deserve some explanations about my changes: I've added fediverse support to better-backgrounds starting with Mastodon, which is a messaging platform like X, and then I'd like to add pixelfed, which is more picture oriented and so, probably, more suitable with the applet goal..

In my branch I've changed applet's UUID 'cause while developing it, I've the original installed too, so I think you'd won't merge it as is, so please, drop this MR.

If you think it could be worth to add my contribution to better-backgrounds, I can prepare a better/cleaner contribution preserving original applet name and with cleaner content, just let me know, in case.

Thanks a lot for your work and support.

@simonmicro
Copy link
Copy Markdown
Owner

Hey @mdepa I really think the work in your fork deserves to be merged into this upstream! I think in combination with your extensions I'll then also update the ongoing #26 issue and we have a beautiful, better release :) What do you think?

@mdepa
Copy link
Copy Markdown
Author

mdepa commented Oct 14, 2024 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants