Repository navigation
Fix transform() raising TransformError when renaming an indexed column - #823
Closed
ikatyal2110 wants to merge 1 commit into
Closed
ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
Renaming a column that has an index is valid — the index should be recreated using the new column name. Only dropping a column makes an index unrecoverable and warrants the error.
simonw
reviewed
Aug 12, 2026
Comment on lines
+2861
to
+2864
| elif col in rename: | ||
| index_sql = index_sql.replace( | ||
| quote_identifier(col), quote_identifier(rename[col]) | ||
| ) |
Owner
There was a problem hiding this comment.
This feels too risk, I'm going to look for a better way.
Owner
|
Fixed in 57192ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a column that has an index is renamed via
transform(rename=...), the index can be recreated using the new column name — the error was wrong to treat renaming the same as dropping. The fix updates the stored index SQL to reference the new column name instead of raisingTransformError. Fixes #822.Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--823.org.readthedocs.build/en/823/