Skip to content

Don't add NOT NULL when transform() drops it from a nullable column #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhishekcpp007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't add NOT NULL when transform() drops it from a nullable column #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlite_utils/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3047,8 +3047,8 @@ def fk_with_renamed_columns(fk: ForeignKey) -> ForeignKey:
for key, value in not_null.items():
# Column may have been renamed
key = rename.get(key) or key
if value is False and key in create_table_not_null:
create_table_not_null.remove(key)
if value is False:
create_table_not_null.discard(key)
else:
create_table_not_null.add(key)
elif isinstance(not_null, set):
Expand Down
10 changes: 10 additions & 0 deletions tests/test_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,16 @@ def test_transform_remove_a_not_null(fresh_db):
)


def test_transform_not_null_false_on_nullable_column(fresh_db):
dogs = fresh_db.table("dogs")
dogs.insert({"id": 1, "name": "Cleo", "age": None}, pk="id")
dogs.transform(not_null={"age": False})
assert (
dogs.schema
== 'CREATE TABLE "dogs" (\n "id" INTEGER PRIMARY KEY,\n "name" TEXT,\n "age" TEXT\n)'
)


@pytest.mark.parametrize("not_null", [{"age"}, {"age": True}])
def test_transform_add_not_null_with_rename(fresh_db, not_null):
dogs = fresh_db.table("dogs")
Expand Down
Loading