Repository navigation
docs: tracker — questdb#7568 reviewed; DEALLOCATE ALL will succeed but release nothing - #151
Merged
Merged
Conversation
…t release nothing The project's founder reviewed the community fix for our #7567 on 2026-09-27: approve with comments. His instrumented runs found that with the fix DEALLOCATE ALL is parsed as a statement named ALL, so it succeeds and releases nothing; prepared statements survive it and re-preparing a name fails with duplicate statement. He has drafted that as an issue and offered to file it. Our report covered the NullPointerException and said DEALLOCATE ALL should succeed as a no-op when nothing is prepared; it did not test with statements present, which is the case that matters for a pooled connection's session reset. The row says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuestDB's founder (bluestreak01) reviewed questdb/questdb#7568 — the community fix for our #7567 — on 2026-09-27: approve with comments, two changes asked of the author before merge, CI green.
The row records the part that matters to this project. From instrumented runs he found that with the fix,
DEALLOCATE ALLsucceeds but releases nothing: it is parsed asDEALLOCATE "ALL", a lookup for a statement literally namedALL, so prepared statements survive it and re-preparing the same name fails withduplicate statement. He traced psycopg 3's behaviour (it sendsDEALLOCATE ALLafterROLLBACK/DROP/ALTER, then prepares under new names) to conclude statements would accumulate per connection towardpg.named.statement.limit. He drafted it as an issue (his A2) and offered to file it; nothing is filed yet.An honest note on our own report. #7567 covered the
NullPointerExceptionand stated thatDEALLOCATE ALLshould succeed "as a no-op when nothing is prepared". It never tested with statements present — which is exactly the case a pooled connection's session reset depends on. So the fix we asked for turns a loud error into a silent non-reset. The row says that plainly rather than treating #7568 as closing the matter.Nothing filed by us: the founder has the draft and offered to file it. When it appears, our reproduction with statements present and the pooling impact go on it as the reporter of the parent issue; the reply scan now watches for it.
docs/compatibility.jsonregenerated, no content change.