fix: resolve critical bugs from code review#1
Merged
Conversation
- Fix corrupted _redis_url() in api.py (lines 115-127 were garbled) - Fix global_exception_handler to stop leaking stack traces to clients - Fix TranslationVerifier warnings nesting bug (list of lists -> flat list) - Remove hardcoded mock claim_text in tasks.py parse_docs() - Rewrite tests/test_skills.py for current Skills API (16 tests, all passing) - Add patentflow-data volume to docker-compose.yml for data persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bug Fixes
🔴 Critical
_redis_url()function — lines 115-127 were garbled, merging the return statement with@app.postdecorator. Restored_redis_client(), queue constants, and route decorator.warningsfield passing nested list ([[str]]) instead of flat list ([str]), causing Pydantic validation error on CRITICAL/Warning translations.global_exception_handlerno longer returnsstr(exc)to clients (was leaking internal paths/stack traces). Errors now logged server-side only.claim_textandprior_art_text— they silently overrode user input. Now defaults to empty string; mock OA file still loaded as fallback when no input provided.💡 Improvements
patentflow-datanamed volume toapiandworkerservices, persistingdata/(SQLite DB, vector store, output) across container restarts.Test results: 20/20 passing ✅