Skip to content

Add active states to top-level nav menu items - #909

Open
1ockwood wants to merge 1 commit into
sissbruecker:masterfrom
1ockwood:nav-menu-active-states
Open

Add active states to top-level nav menu items#909
1ockwood wants to merge 1 commit into
sissbruecker:masterfrom
1ockwood:nav-menu-active-states

Conversation

@1ockwood

Copy link
Copy Markdown

Changes

This is a fairly simple change that adds active states to the top-level nav menu items on large viewports. As a new user, the first time I clicked around, I expected to see that sort of feedback to give a sense of where I am in the app.

I kept it to the "desktop" version of the nav menu only, as the "mobile" menu is structured a bit differently (the top-level "Bookmarks" item being grouped at the same hierarchy as the other Bookmarks entries), and I don't necessarily feel it needs the same feedback in that context. Happy to experiment with that though if you feel otherwise.

In the same vein, I also tweaked the styles for hover states for the nav menu links.

Screenshots

Dark Mode

nav-menu-active-items-dark

nav-menu-active-items-dark.mov

Light Mode

nav-menu-active-items-light

nav-menu-active-items-light.mov

@tkafka

tkafka commented May 13, 2025

Copy link
Copy Markdown

I love this! Any chance to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants