Skip to content

fix: fixed incorrect wrap for process's stdio container#317

Open
sssooonnnggg wants to merge 1 commit into
skypjack:mainfrom
sssooonnnggg:main
Open

fix: fixed incorrect wrap for process's stdio container#317
sssooonnnggg wants to merge 1 commit into
skypjack:mainfrom
sssooonnnggg:main

Conversation

@sssooonnnggg

@sssooonnnggg sssooonnnggg commented Oct 16, 2024

Copy link
Copy Markdown

The stdio api of the process should ensure the calling order.

According to libuv's documentation and test cases, where stdio[0] is designated as stdin, stdio[1] as stdout, and stdio[2] as stderr.

When specifying stdin for the child process as stdin_pipe, stdout to a custom file, and stderr as stderr_pipe:

process_handle.stdio(stdin_pipe, flag)
process_handle.stdio(stdout_file_handle, flag)
process_handle.stdio(stderr_pipe, flag)

The previous uvw implementation incorrectly concatenates it as follows because it used two vectors seperately:

stdio[0] = stdout_file_handle
stdio[1] = stdin_pipe
stdio[2] = stderr_pipe

This is not the correct behaviour

This PR try to fix this.😊

Libuv spawn examples: https://github.com/libuv/libuv/blob/v1.x/test/test-spawn.c

@sssooonnnggg

Copy link
Copy Markdown
Author

Here we can see the convention of how libuv deal with the indexing of stdio,0 is stdin,1 is stdout,2 is stderr
https://github.com/libuv/libuv/blob/fbe2d85bd5a5c370a8cacea92b3bdfbd9f98a530/src/win/process.c#L1018-L1020

@skypjack
skypjack self-requested a review October 17, 2024 16:26
@skypjack skypjack self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants