Add include directories to vendored uv target#332
Open
russkel wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am using uvw and find the vendored uv static lib handy. However I was not able to simply just link to uvw and uv as it would result in missing include issues, because the uv directory is put into a nested include directory.
I am not sure if this was intentional or a mistake - if it was me I would have uv and uvw header directories at the same level and not nested. In any case, this fixes the missing include error.
In addition, any of the
uv::namespace does not seem to be exported either as they are build time aliases. I changed the README to reflect that.I bumped to latest libuv because I needed TCP keepalive_ex functionality. Let me know if you want me to drop that commit.