fix(datetime.dst): pass Gregorian to tzinfo.dst()#188
Open
5j9 wants to merge 1 commit into
Open
Conversation
Standard timezone libraries and databases expect standard Gregorian datetime objects to resolve DST offsets correctly. Passing a Jalali datetime object (`self`) causes two major issues: 1. It results in silent bugs because the database evaluates rules for the Jalali year (e.g., 1405 AD instead of the converted 2026 AD). 2. It can raise type/attribute errors if strict type-checking is enforced. This converts the instance to its Gregorian representation using `self.togregorian()` before passing it to `tzinfo.dst()`. Also: - Removes the outdated TODO comment on the `dst` method. - Adds unit tests using zoneinfo to verify DST calculations for both aware and naive jdatetime instances.
Owner
|
@5j9 Thanks! Any chance we could backport this to v6? |
Owner
|
I meant to version v5! |
Contributor
Author
Hi @slashmili, Since there isn't a dedicated maintenance branch for |
Contributor
Author
Oh, sure. I'll create v5 branch and cherry-pick it there. |
Contributor
Author
Owner
|
Done! I created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard timezone libraries and databases expect standard Gregorian datetime objects to resolve DST offsets correctly. Passing a Jalali datetime object (
self) causes two major issues:This converts the instance to its Gregorian representation using
self.togregorian()before passing it totzinfo.dst().Also:
dstmethod.