Skip to content

Support PHP 8.4 & 8.5 in CI #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odan merged 2 commits into from
Nov 2, 2025
Merged

Support PHP 8.4 & 8.5 in CI #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db546ff
Remove .travis.yml
akrabat Nov 2, 2025
6d33186
Support PHP 8.4 & 8.5 in CI
akrabat Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [7.4, 8.0, 8.1, 8.2, 8.3]
php: [7.4, 8.0, 8.1, 8.2, 8.3, 8.4, 8.5]
include:
- php: 8.2
- php: 8.4
analysis: true

steps:
Expand Down
26 changes: 0 additions & 26 deletions .travis.yml
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions tests/CacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected function createResponse(): ResponseInterface
*
* @return RequestHandlerInterface
*/
protected function createRequestHandler(ResponseInterface $response = null): RequestHandlerInterface
protected function createRequestHandler(?ResponseInterface $response): RequestHandlerInterface
{
$response = $response ?? $this->createResponse();

Expand All @@ -67,7 +67,7 @@ public function testCacheControlHeader()
$cache = new Cache('public', 86400);
$req = $this->requestFactory();

$res = $cache->process($req, $this->createRequestHandler());
$res = $cache->process($req, $this->createRequestHandler(null));

$cacheControl = $res->getHeaderLine('Cache-Control');

Expand All @@ -79,7 +79,7 @@ public function testCacheControlHeaderWithMustRevalidate()
$cache = new Cache('private', 86400, true);
$req = $this->requestFactory();

$res = $cache->process($req, $this->createRequestHandler());
$res = $cache->process($req, $this->createRequestHandler(null));

$cacheControl = $res->getHeaderLine('Cache-Control');

Expand All @@ -91,7 +91,7 @@ public function testCacheControlHeaderWithZeroMaxAge()
$cache = new Cache('private', 0, false);
$req = $this->requestFactory();

$res = $cache->process($req, $this->createRequestHandler());
$res = $cache->process($req, $this->createRequestHandler(null));

$cacheControl = $res->getHeaderLine('Cache-Control');

Expand Down