fix: Discord @mention filter for group channels#320
Draft
Conversation
DMs still go through. Group channel messages require bot @mention at integration level — prevents flooding and unnecessary task creation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
||
| if not isinstance(message.channel, discord.DMChannel): | ||
| if self.client.user not in message.mentions: | ||
| return |
Contributor
There was a problem hiding this comment.
This is a good fix, but it should be in inbound_activity_to_task, in other means, it should be bot responsibility to decide, so it should be in the overridable function
Also after this we can call always ckit_kanban.bot_kanban_post_into_inprogress
no need to call ckit_kanban.bot_kanban_post_into_inbox if we don't respond to normal messages
4 tasks
humbertoyusta
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code