enclave/server: make response emitter safe for concurrent use - #33
Merged
Conversation
|
👋 cfal, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cfal
force-pushed
the
response-emitter-race
branch
from
August 1, 2026 09:46
3cf101d to
d9d34aa
Compare
vreff
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chainlink-commonexecutes capability calls in asynchronous goroutines, and a workflow can have multiple calls in flight within the same execution. These calls share a per-executionResponseEmitter, which currently appends events without synchronization. This change protects event collection with a mutex and builds both response representations from a consistent snapshot, preventing data races and lost observability events during parallel host calls.