Merged
Conversation
All ci.yml jobs (shellcheck, shfmt, markdownlint, yamllint, python-lint, html-lint, bats, configuration-validation) are fully covered by local pre-commit hooks. The macos-latest BATS runner was the most expensive at 10x Linux runner cost. Remove ci.yml and its CI-only config files (.shellcheckrc, .yamllint), and the now-dead CI badge from README. Retain claude.yml and claude-blocking-review.yml (GitHub-event-driven, no local equivalent). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
5 tasks
smartwatermelon
added a commit
to smartwatermelon/archive-resolver
that referenced
this pull request
Apr 10, 2026
The shellcheck job in ci.yml duplicates the global shell-lint pre-commit hook (`~/.config/pre-commit/config.yaml` runs `lint-shell.sh` which invokes shellcheck on every commit). Local multi-step review (Phase 2) covers the same ground for any commit pushed via the authorized workflow. Keep the syntax and dry-run jobs — they validate mirrors.txt format and exercise install.sh under Linux dry-run, neither of which is covered by local hooks. Also keep release.yml's pre-release shellcheck step as a belt-and-suspenders safeguard before publishing tagged releases. Update CLAUDE.md "CI workflows" section so the description matches reality and notes where shellcheck now lives. Same pattern as smartwatermelon/mac-server-setup#118 and mac-dev-server-setup#25. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
smartwatermelon
added a commit
to smartwatermelon/archive-resolver
that referenced
this pull request
Apr 10, 2026
The shellcheck job in ci.yml duplicates the global shell-lint pre-commit hook (`~/.config/pre-commit/config.yaml` runs `lint-shell.sh` which invokes shellcheck on every commit). Local multi-step review (Phase 2) covers the same ground for any commit pushed via the authorized workflow. Keep the syntax and dry-run jobs — they validate mirrors.txt format and exercise install.sh under Linux dry-run, neither of which is covered by local hooks. Also keep release.yml's pre-release shellcheck step as a belt-and-suspenders safeguard before publishing tagged releases. Update CLAUDE.md "CI workflows" section so the description matches reality and notes where shellcheck now lives. Same pattern as smartwatermelon/mac-server-setup#118 and mac-dev-server-setup#25. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml— all 9 jobs (shellcheck, shfmt, markdownlint, yamllint, python-lint, html-lint, bats, detect-changes, configuration-validation) are fully covered by local pre-commit hooks.shellcheckrc,.yamllint) — identical settings exist in~/.shellcheckrcand are unused outside CIclaude.ymlandclaude-blocking-review.yml(GitHub-event-driven, no local equivalent)Cost impact: The
batsjob ran onmacos-latestat 10x Linux runner cost ($0.08/min). All other jobs ran onubuntu-latest. Every push and PR triggered these redundant checks.Test plan
.shellcheckrccontent matches global~/.shellcheckrcci.yml🤖 Generated with Claude Code