Conversation
fogti
force-pushed
the
no-std-minimal
branch
5 times, most recently
from
bccd5f9 to
fb08aa6
Compare
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
LGTM but isn't this a breaking change?
|
Maybe (it does break building |
fogti
force-pushed
the
no-std-minimal
branch
3 times, most recently
from
4dd839b to
51484cf
Compare
|
(Marked as draft because we need to wait for the current release to get finished) |
Yeah, adding a default feature that gates existing functionality/api, is a breaking change for sure. |
| #[cfg(feature = "std")] | ||
| let mut rng = fastrand::Rng::new(); | ||
| #[cfg(not(feature = "std"))] | ||
| let mut rng = fastrand::Rng::with_seed(0); |
There was a problem hiding this comment.
I would recommend using either a pre-set value other than 0 or the address of a function as the seed here.
There was a problem hiding this comment.
Is this better (unfortunately, one can't use the address of the current function, because it's async and is unnameable (at least I couldn't find a way to state it).
fogti
force-pushed
the
no-std-minimal
branch
from
9d863bd to
ba895d2
Compare
Co-authored-by: Έλλεν Εμίλια Άννα Zscheile <fogti+devel@ytrizja.de>
4 participants
Cherry-picked 78cfea8.
Note that this doesn't make
async-executoractually work in ano-stdsetting by default (due to lack of locks, etc.), but it puts all the stuff in place that will always be necessary, no matter which lock implementation is actually used.