Tune rollout config: TP-aware FCA/SD thresholds - #268
Open
sfc-gh-mhidayetoglu wants to merge 1 commit into
Open
Conversation
sfc-gh-mhidayetoglu
requested review from
sfc-gh-goliaro,
sfc-gh-jrasley and
sfc-gh-reyazda
as code owners
June 29, 2026 23:54
| if use_fca: | ||
| kwargs.setdefault("compilation_config", {"cudagraph_mode": "PIECEWISE"}) | ||
| kwargs.setdefault("forest_cascade_attn_configs", "{}") | ||
| if tp_size == 8: |
Collaborator
There was a problem hiding this comment.
Is there a rationale for mapping of tp_size to min_batch_size? It seems to be 20x for tp_size=8 and otherwise 12x.
Collaborator
There was a problem hiding this comment.
Also would we want different values depending on the model we are serving? Would this be best defined in the known model configs?
Collaborator
There was a problem hiding this comment.
Yes, this seems like a perfect location for default tuning values.
| else: | ||
| kwargs.pop("forest_cascade_attn_configs", None) | ||
| if use_fca: | ||
| if tp_size == 8: |
Collaborator
There was a problem hiding this comment.
Similar to above, is there a rule mapping between tp_size and hard_disable_by_batch_size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results on an H200 node (txt2sql recipe)
