Skip to content

Fix Windows builds and old-driver CI tests - #1338

Open
zeroshade wants to merge 1 commit into
snowflakedb:mainfrom
zeroshade:fix/windows-and-old-driver-ci
Open

Fix Windows builds and old-driver CI tests#1338
zeroshade wants to merge 1 commit into
snowflakedb:mainfrom
zeroshade:fix/windows-and-old-driver-ci

Conversation

@zeroshade

Copy link
Copy Markdown
Contributor

Summary

  • use the vcpkg OpenSSL installation for Windows x64 Python wheels and reuse the initialized MSVC environment on x64 and ARM64
  • avoid loading the new Node native core in old-driver reference tests
  • make JDBC table-privilege assertions independent of row ordering
  • tolerate structured-type session parameters that have been retired after becoming defaults

Validation

  • actionlint -ignore SC2086 on the Python wheel workflow
  • Gradle checkstyleTest testClasses
  • Node fmt:check and lint:check
  • focused TypeScript compilation of the changed Node helper
  • old-driver constants test: 3 passed
  • git diff --check

Windows wheel execution and credentialed JDBC integration coverage remain delegated to CI. The existing ODBC old-reference credential failures require repository-secret repair.

Copilot AI lite review requested due to automatic review settings August 11, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI/workflows and a few test utilities to improve Windows build reliability and reduce flakiness in cross-driver/reference test runs, while making JDBC integration assertions more robust across backend variations.

Changes:

  • Node.js: avoid importing the new SDK entrypoint (and eagerly loading the native core) when running the “old driver” E2E reference project.
  • JDBC: make table-privilege assertions insensitive to row ordering, and tolerate structured-type session parameters that may be retired once defaults change.
  • CI: adjust Windows Python wheel builds to use vcpkg-provided OpenSSL and reuse the already-initialized MSVC environment across steps.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
nodejs/tests/e2e/utils/index.ts Conditionally defers importing src/index.js so old-driver reference runs don’t load the new native core.
jdbc/src/test/java/net/snowflake/client/api/resultset/metadata/SnowflakeResultSetMetaDataImplStructuredTypesTest.java Adds a helper to set session parameters only when supported (tolerating retired feature-gate parameters).
jdbc/src/test/java/net/snowflake/client/api/metadata/SnowflakeDatabaseMetaDataTests.java Updates table privilege assertions to not depend on result-set row ordering.
.github/workflows/_build-python-wheels.yml Switches Windows x64 wheels away from vendored OpenSSL, adds OpenSSL/MSVC setup steps, and reuses MSVC env during wheel build.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants