Fix Windows builds and old-driver CI tests - #1338
Open
zeroshade wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI/workflows and a few test utilities to improve Windows build reliability and reduce flakiness in cross-driver/reference test runs, while making JDBC integration assertions more robust across backend variations.
Changes:
- Node.js: avoid importing the new SDK entrypoint (and eagerly loading the native core) when running the “old driver” E2E reference project.
- JDBC: make table-privilege assertions insensitive to row ordering, and tolerate structured-type session parameters that may be retired once defaults change.
- CI: adjust Windows Python wheel builds to use vcpkg-provided OpenSSL and reuse the already-initialized MSVC environment across steps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nodejs/tests/e2e/utils/index.ts |
Conditionally defers importing src/index.js so old-driver reference runs don’t load the new native core. |
jdbc/src/test/java/net/snowflake/client/api/resultset/metadata/SnowflakeResultSetMetaDataImplStructuredTypesTest.java |
Adds a helper to set session parameters only when supported (tolerating retired feature-gate parameters). |
jdbc/src/test/java/net/snowflake/client/api/metadata/SnowflakeDatabaseMetaDataTests.java |
Updates table privilege assertions to not depend on result-set row ordering. |
.github/workflows/_build-python-wheels.yml |
Switches Windows x64 wheels away from vendored OpenSSL, adds OpenSSL/MSVC setup steps, and reuses MSVC env during wheel build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Windows wheel execution and credentialed JDBC integration coverage remain delegated to CI. The existing ODBC old-reference credential failures require repository-secret repair.