Skip to content

Add INSERT support for OBJECT - #320

Draft
lucg wants to merge 2 commits into
snowflakedb:mainfrom
lucg:feature/insert-regex-rewrite
Draft

Add INSERT support for OBJECT#320
lucg wants to merge 2 commits into
snowflakedb:mainfrom
lucg:feature/insert-regex-rewrite

Conversation

@lucg

@lucg lucg commented Jul 20, 2022

Copy link
Copy Markdown

Requires #319

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes (half of) Semistructured Data support for UPDATE and INSERT #107

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    When OBJECTs are inserted, the query is rewritten to use a SELECT to support the use of parse_json.

This suggestion originated from the SQLAlchemy maintainer:
sqlalchemy/sqlalchemy#7894 (reply in thread)

@lucg
lucg requested a review from sfc-gh-mkeller as a code owner July 20, 2022 16:54
@lucg
lucg marked this pull request as draft July 20, 2022 16:54
@lucg

lucg commented Jul 20, 2022

Copy link
Copy Markdown
Author

Waiting for #319

@sfc-gh-mkeller
sfc-gh-mkeller removed their request for review July 2, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant