Fix ignored direct time travel parameters in DataFrameReader - #4303
Open
fallintoplace wants to merge 1 commit into
Open
Fix ignored direct time travel parameters in DataFrameReader#4303fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
requested review from
sfc-gh-aling,
sfc-gh-jzeng and
sfc-gh-yixie
August 2, 2026 00:25
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statement,offset,timestamp, andstreamarguments when choosing the time-travel parameter pathPreviously,
DataFrameReader.table()only selected the direct-parameter path whentime_travel_modeor an Iceberg-specific argument was set. A selector such asoffset=-60was therefore dropped before reachingSession.table, silently returning the current table instead of raising the existing missing-mode validation error.Testing
python -m pytest tests/unit/test_dataframe.py tests/unit/test_utils.py -qpre-commit run --files src/snowflake/snowpark/dataframe_reader.py tests/unit/test_dataframe.py