Skip to content

Fix ignored direct time travel parameters in DataFrameReader - #4303

Open
fallintoplace wants to merge 1 commit into
snowflakedb:mainfrom
fallintoplace:fix-reader-direct-time-travel-params
Open

Fix ignored direct time travel parameters in DataFrameReader#4303
fallintoplace wants to merge 1 commit into
snowflakedb:mainfrom
fallintoplace:fix-reader-direct-time-travel-params

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • recognize direct statement, offset, timestamp, and stream arguments when choosing the time-travel parameter path
  • preserve the documented behavior that direct parameters override reader options
  • add public API regression coverage for each affected selector

Previously, DataFrameReader.table() only selected the direct-parameter path when time_travel_mode or an Iceberg-specific argument was set. A selector such as offset=-60 was therefore dropped before reaching Session.table, silently returning the current table instead of raising the existing missing-mode validation error.

Testing

  • python -m pytest tests/unit/test_dataframe.py tests/unit/test_utils.py -q
  • pre-commit run --files src/snowflake/snowpark/dataframe_reader.py tests/unit/test_dataframe.py

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@fallintoplace

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant