SNOW-2912540: use IS_V5_DRIVER for cursor request_id access - #4314
Open
sfc-gh-fpawlowski wants to merge 1 commit into
Open
SNOW-2912540: use IS_V5_DRIVER for cursor request_id access#4314sfc-gh-fpawlowski wants to merge 1 commit into
sfc-gh-fpawlowski wants to merge 1 commit into
Conversation
The UD's SnowflakeCursor exposes the client-generated request UUID as a public `request_id` property; `_request_id` is only a backward-compat alias slated for removal. The legacy v4 connector is the opposite: it only ever sets `self._request_id` as a plain instance attribute and has no public `request_id` property. Branch on IS_V5_DRIVER in the one call site that reads this (execute_and_notify_query_listener) and its unit test mock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sfc-gh-fpawlowski
requested review from
sfc-gh-aling,
sfc-gh-jzeng and
sfc-gh-yuwang
and removed request for
a team
August 13, 2026 09:55
This was referenced Aug 13, 2026
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SnowflakeCursorexposes the client-generated request UUID as a publicrequest_idproperty;_request_idis only a backward-compat alias slated for removal.self._request_idas a plain instance attribute incursor.py, with no publicrequest_idproperty at all.IS_V5_DRIVERat the one call site that reads this —execute_and_notify_query_listenerinserver_connection.py— and its unit test mock._request_id-named attributes in the repo:AstBatch._request_idandAstBuilder's request-id generation are Snowpark's own self-generated UUIDs for the AST Bind/Eval batching protocol — unrelated to the connector cursor, same name by coincidence.Test plan
grep -rn "\._request_id\b" src/ tests/confirms only the AST-batch (unrelated) and the fixed call sites remainStack (via Graphite)
🤖 Generated with Claude Code