Skip to content

fix: resolve media permission bugs and improve device access UX#35

Merged
obrucheoghene merged 1 commit into
softhon:mainfrom
obrucheoghene:main
Mar 25, 2026
Merged

fix: resolve media permission bugs and improve device access UX#35
obrucheoghene merged 1 commit into
softhon:mainfrom
obrucheoghene:main

Conversation

@obrucheoghene
Copy link
Copy Markdown
Collaborator

  • Fix requestCameraPermission filtering audioinput instead of videoinput
  • Fix toggleMic calling requestCameraPermission instead of requestMicPermission
  • Replace alert() calls with sonner toast.error() using structured title/description
  • Show toast when requestCameraAndMicPermissions is denied (was silently swallowed)
  • Add proactive navigator.permissions check on pre-join screen with actionable denied toast
  • Add micPending/cameraPending loading state; show spinner on buttons during acquisition

Pull Request for Mitsi

Thank you for contributing to Mitsi! Please provide the following details to help us review your changes.

Description

Describe the purpose of this pull request and the changes introduced. What problem does it solve or what feature does it add?

Related Issues

Link any related issues (e.g., #123) or explain if this is a new feature or fix.

Changes Made

List the key changes made in this pull request (e.g., modified files, new features, bug fixes).

Testing

Describe how you tested your changes. Did you add or update tests in the tests folder?

Checklist

Please confirm the following by checking the boxes:

  • I have read the CONTRIBUTING.md file.
  • I have run npm run lint locally to ensure code style (source in src, tests in tests) is correct.
  • I have run npm run build locally to verify TypeScript compilation to dist.
  • I have run npm run test locally to confirm all tests pass.
  • My changes adhere to the MIT License (see LICENSE).
  • I have updated documentation (e.g., README, comments) if necessary.

Additional Notes

Add any other information relevant to this pull request, such as screenshots, performance impacts, or questions for reviewers.


CI Notes: The CI workflow will automatically run npm run lint, npm run build, and npm run test on this pull request. Ensure these pass locally to avoid CI failures. See CONTRIBUTING.md for setup instructions.

- Fix requestCameraPermission filtering audioinput instead of videoinput
- Fix toggleMic calling requestCameraPermission instead of requestMicPermission
- Replace alert() calls with sonner toast.error() using structured title/description
- Show toast when requestCameraAndMicPermissions is denied (was silently swallowed)
- Add proactive navigator.permissions check on pre-join screen with actionable denied toast
- Add micPending/cameraPending loading state; show spinner on buttons during acquisition
@obrucheoghene obrucheoghene merged commit d642ae7 into softhon:main Mar 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant