Feat/long file playback by mdydek · Pull Request #993 · software-mansion/react-native-audio-api

mdydek · 2026-03-20T10:28:17Z

Closes #735

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Linked relevant issue
Updated relevant documentation
Added/Conducted relevant tests
Performed self-review of the code
Updated Web Audio API coverage
Added support for web
Updated old arch android spec file

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.h

packages/react-native-audio-api/src/development/react/Audio/Audio.tsx

packages/react-native-audio-api/src/development/react/Audio/types.ts

poneciak57 · 2026-03-26T10:27:50Z

...t-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioFileSourceNodeHostObject.cpp

+void AudioFileSourceNodeHostObject::setOnPositionChangedCallbackId(uint64_t callbackId) {
+  auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);
+
+  auto event = [sourceNode, callbackId](BaseAudioContext &) {
+    sourceNode->setOnPositionChangedCallbackId(callbackId);
+  };
+
+  sourceNode->unregisterOnPositionChangedCallback(onPositionChangedCallbackId_);
+  sourceNode->scheduleAudioEvent(std::move(event));
+  onPositionChangedCallbackId_ = callbackId;
+}


Suggested change

void AudioFileSourceNodeHostObject::setOnPositionChangedCallbackId(uint64_t callbackId) {

auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);

auto event = [sourceNode, callbackId](BaseAudioContext &) {

sourceNode->setOnPositionChangedCallbackId(callbackId);

};

sourceNode->unregisterOnPositionChangedCallback(onPositionChangedCallbackId_);

sourceNode->scheduleAudioEvent(std::move(event));

onPositionChangedCallbackId_ = callbackId;

}

void AudioFileSourceNodeHostObject::setOnPositionChangedCallbackId(uint64_t callbackId) {

auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);

auto event = [sourceNode, callbackId, onPositionChangedCallbackId_ = this.onPositionChangedCallbackId_](BaseAudioContext &) {

sourceNode->unregisterOnPositionChangedCallback(onPositionChangedCallbackId_);

sourceNode->setOnPositionChangedCallbackId(callbackId);

};

sourceNode->scheduleAudioEvent(std::move(event));

onPositionChangedCallbackId_ = callbackId;

}

why? unregisterOnPositionChangedCallback(onPositionChangedCallbackId_) calls audioEventHandlerRegistry_->unregisterHandler(AudioEvent::ENDED, callbackId) that calls invokeAsync on JS thread

but what if we call a callback in between unregistration and setOnPositionChangeCallback
in this case we try to invoke non existent callback
are we sure this will work fine?

map with callback is accessed only inside invokeAsync block, so indeed it is thread safe

poneciak57 · 2026-03-26T10:28:28Z

...t-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioFileSourceNodeHostObject.cpp

+void AudioFileSourceNodeHostObject::setOnEndedCallbackId(uint64_t callbackId) {
+  auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);
+
+  auto event = [sourceNode, callbackId](BaseAudioContext &) {
+    sourceNode->setOnEndedCallbackId(callbackId);
+  };
+
+  sourceNode->unregisterOnEndedCallback(onEndedCallbackId_);
+  sourceNode->scheduleAudioEvent(std::move(event));
+  onEndedCallbackId_ = callbackId;
+}


Suggested change

void AudioFileSourceNodeHostObject::setOnEndedCallbackId(uint64_t callbackId) {

auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);

auto event = [sourceNode, callbackId](BaseAudioContext &) {

sourceNode->setOnEndedCallbackId(callbackId);

};

sourceNode->unregisterOnEndedCallback(onEndedCallbackId_);

sourceNode->scheduleAudioEvent(std::move(event));

onEndedCallbackId_ = callbackId;

}

void AudioFileSourceNodeHostObject::setOnEndedCallbackId(uint64_t callbackId) {

auto sourceNode = std::static_pointer_cast<AudioFileSourceNode>(node_);

auto event = [sourceNode, callbackId, onEndedCallbackId_ = this.onEndedCallbackId_](BaseAudioContext &) {

sourceNode->unregisterOnEndedCallback(onEndedCallbackId_);

sourceNode->setOnEndedCallbackId(callbackId);

};

sourceNode->scheduleAudioEvent(std::move(event));

onEndedCallbackId_ = callbackId;

}

same as above

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp

maciejmakowski2003 · 2026-03-26T11:39:23Z

packages/react-native-audio-api/common/cpp/audioapi/libs/ffmpeg/FFmpegDecoding.cpp

+  size_t frames = interleaved.size() / static_cast<size_t>(channels);
+  auto buf = std::make_shared<AudioBuffer>(frames, channels, static_cast<float>(sample_rate));
+  for (int c = 0; c < channels; ++c) {
+    auto span = buf->getChannel(c)->span();
+    for (size_t i = 0; i < frames; ++i) {
+      span[i] = interleaved[i * static_cast<size_t>(channels) + static_cast<size_t>(c)];
+    }
+  }
+  return buf;


you can use AudioBuffer method deinterleaveFrom

maciejmakowski2003 · 2026-03-26T11:41:22Z

...act-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioFileSourceNodeHostObject.h

+  JSI_PROPERTY_GETTER_DECL(volume);
+  JSI_PROPERTY_SETTER_DECL(volume);
+  JSI_PROPERTY_GETTER_DECL(loop);
+  JSI_PROPERTY_SETTER_DECL(loop);
+  JSI_PROPERTY_GETTER_DECL(currentTime);
+  JSI_PROPERTY_GETTER_DECL(duration);
+  JSI_PROPERTY_SETTER_DECL(onPositionChanged);
+  JSI_PROPERTY_SETTER_DECL(onEnded);


Suggested change

JSI_PROPERTY_GETTER_DECL(volume);

JSI_PROPERTY_SETTER_DECL(volume);

JSI_PROPERTY_GETTER_DECL(loop);

JSI_PROPERTY_SETTER_DECL(loop);

JSI_PROPERTY_GETTER_DECL(currentTime);

JSI_PROPERTY_GETTER_DECL(duration);

JSI_PROPERTY_SETTER_DECL(onPositionChanged);

JSI_PROPERTY_SETTER_DECL(onEnded);

JSI_PROPERTY_GETTER_DECL(volume);

JSI_PROPERTY_GETTER_DECL(loop);

JSI_PROPERTY_GETTER_DECL(currentTime);

JSI_PROPERTY_GETTER_DECL(duration);

JSI_PROPERTY_SETTER_DECL(volume);

JSI_PROPERTY_SETTER_DECL(loop);

JSI_PROPERTY_SETTER_DECL(onPositionChanged);

JSI_PROPERTY_SETTER_DECL(onEnded);

maciejmakowski2003 · 2026-03-26T11:46:04Z

...t-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioFileSourceNodeHostObject.cpp

+
+JSI_PROPERTY_GETTER_IMPL(AudioFileSourceNodeHostObject, duration) {
+  auto node = std::static_pointer_cast<AudioFileSourceNode>(node_);
+  return {node->getDuration()};


you can store duration in shadow state, as well as volume and loop.

maciejmakowski2003 · 2026-03-26T11:46:28Z

packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.cpp

+std::shared_ptr<AudioFileSourceNode> BaseAudioContext::createFileSource(
+    const AudioFileSourceOptions &options) {
+  auto fileSource = std::make_shared<AudioFileSourceNode>(shared_from_this(), options);
+  //  graphManager_->addProcessingNode(fileSource);


maciejmakowski2003 · 2026-03-26T11:51:22Z

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.cpp

+    ma_decoder_config config =
+        ma_decoder_config_init(ma_format_f32, 0, static_cast<ma_uint32>(context->getSampleRate()));
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
+    ma_decoding_backend_vtable *customBackends[] = {
+        ma_decoding_backend_libvorbis, ma_decoding_backend_libopus};
+    // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-array-to-pointer-decay)
+    config.ppCustomBackendVTables = customBackends;
+    config.customBackendCount = sizeof(customBackends) / sizeof(customBackends[0]);
+
+    maDecoder_ = std::make_unique<ma_decoder>();
+    ma_result result;
+    if (useFilePath) {
+      result = ma_decoder_init_file(state->filePath.c_str(), &config, maDecoder_.get());
+    } else {
+      result = ma_decoder_init_memory(
+          state->memoryData.data(), state->memoryData.size(), &config, maDecoder_.get());
+    }
+
+    if (result == MA_SUCCESS) {
+      state->channels = static_cast<int>(maDecoder_->outputChannels);
+      state->sampleRate = static_cast<float>(maDecoder_->outputSampleRate);
+      ma_uint64 length = 0;
+      if (ma_decoder_get_length_in_pcm_frames(maDecoder_.get(), &length) == MA_SUCCESS) {
+        duration_ = static_cast<double>(length) / state->sampleRate;
+      }
+    } else {
+      ma_decoder_uninit(maDecoder_.get());
+      maDecoder_.reset();
+    }
+  }


is there any way to hide ma decoder initialization impl details inside MiniAudio Decoder class?

maciejmakowski2003 · 2026-03-26T11:54:03Z

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.cpp

+  ma_uint64 framesRead = 0;
+  ma_decoder_read_pcm_frames(maDecoder_.get(), buf, frameCount, &framesRead);


lets hide mini audio impl details

maciejmakowski2003 · 2026-03-26T11:55:55Z

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.cpp

+  for (size_t i = 0; i < frameCount; i++) {
+    for (int ch = 0; ch < numOutputChannels; ch++) {
+      int srcCh = ch < state.channels ? ch : state.channels - 1;
+      processingBuffer->getChannel(ch)->span()[destSampleOffset + i] =
+          vol * state.interleavedBuffer[i * state.channels + srcCh];
+    }
+  }


use deinterleaveFrom AudioBuffer method

maciejmakowski2003 · 2026-03-26T11:57:43Z

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.cpp

+AudioFileSourceNode::AudioFileSourceNode(
+    const std::shared_ptr<BaseAudioContext> &context,
+    const AudioFileSourceOptions &options)
+    : AudioNode(context, options),


I should inherit from AudioScheduledSourceNode

it is highly misleading that AudioNode that is not a child of ASSN is a source

maciejmakowski2003 · 2026-03-26T12:00:22Z

packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioFileSourceNode.h

+  ffmpegdecoder::FFmpegDecoder ffmpegDecoder_;
+  ffmpegdecoder::FFmpegDecoderConfig cfg;
+#endif // RN_AUDIO_API_FFMPEG_DISABLED
+  std::atomic<bool> filePaused_{false};


maybe it will be better to store state of node like in ASSN. why pause is not send via events queue? I do not think that atomic usage here is necessary. is there any reason behind it?

maciejmakowski2003 and others added 5 commits March 17, 2026 16:52

feat: ai slop long files playback node

56f0f58

feat: file playback

429310a

feat: working ffmpeg files playback

feaecf6

feat: alpha integration with audio tag

a54bbe3

feat: basic integration with audio tag

0e1c08a

mdydek added the feature New feature label Mar 20, 2026

mdydek added 2 commits March 20, 2026 11:35

fix: tests

1935fba

fix: testsV2

9b0e748

michalsek requested changes Mar 20, 2026

View reviewed changes

mdydek added 10 commits March 20, 2026 16:22

feat: loop controls state

df70d91

feat: working beta

25e4a63

feat: offload seek to a separate thread

979b34d

chore: removed AudioContent.tsx

923537a

chore: removed .swift file

d8534b8

chore: original .swift file

35bbbac

chore: renamed example

045450a

refactor: cleanup

62bb5ad

refactor: changed spsc strategies

485eca6

refactor: improvements on verbosity

2440c8f

mdydek marked this pull request as ready for review March 26, 2026 09:13

poneciak57 requested changes Mar 26, 2026

View reviewed changes

mdydek added 2 commits March 26, 2026 12:27

feat: static icons try

13f5a37

feat: added ffmpeg flag to options

586cbb9

maciejmakowski2003 requested changes Mar 26, 2026

View reviewed changes

		ma_uint64 framesRead = 0;
		ma_decoder_read_pcm_frames(maDecoder_.get(), buf, frameCount, &framesRead);

Uh oh!

Conversation

mdydek commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mdydek commented Mar 20, 2026 •

edited

Loading