Test improvements - #666
Merged
Merged
Conversation
ZakkeryDaRebel
approved these changes
Jul 22, 2026
ZakkeryDaRebel
left a comment
ZakkeryDaRebel
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, and I have all the tests passing on my machine
mewilker
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Modified the SQL/Memory DAO implementations of getBestSubmissionForPhase() to retreive the best submission by score AND by date, rather than just by score.
This change enabled the SubmissionDaoTest.getBestSubmissionWithDuplicateScore test to work properly, so it has been re-enabled.
I figure I might as well submit this PR now, because having the oldest submission with the highest score will be relevant for #664
Details
Testing