Add FileMaker Cloud authentication#9
Open
steveWinter wants to merge 2 commits intosoliantconsulting:mainfrom
Open
Add FileMaker Cloud authentication#9steveWinter wants to merge 2 commits intosoliantconsulting:mainfrom
steveWinter wants to merge 2 commits intosoliantconsulting:mainfrom
Conversation
Collaborator
|
Thanks for your contribution! I see a few things which would have to be addressed thought:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you may be aware FileMaker cloud uses an alternative initial login process to request the token used for subsequent calls utilising AWS Cognito.
This PR adds a constructor parameter which allows the use of FMCloud to be indicated (defaulting to false) and provides the necessary functionality to login to FileMaker Cloud. The AWS Cognito library is added as a dependency.
Credit to Christos Savva of Velistar Ltd, who did the initial work implementing this in a copy of the the /lib folder which streamlined the process of updating the typescript for this PR.