-
Notifications
You must be signed in to change notification settings - Fork 4
feat : 멘토 페이지 버그 개선 및 border 버그 수정 #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough1. MenteePage 컴포넌트 추가: Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/web/src/app/mentor/_ui/MentorClient/index.tsx`:
- Around line 23-41: The token-refresh effect currently re-runs even when
refreshStatus is "failed", causing repeated redirect loops; update the guard in
the attemptTokenRefresh logic (inside the useEffect) to abort if refreshStatus
=== "failed" (or add an explicit check like if (refreshStatus === "failed")
return), ensuring you only proceed when refreshStatus is not "failed" and
isInitialized is true and no other refresh is in progress; keep using the
existing symbols attemptTokenRefresh, refreshStatus, setRefreshStatus,
isRefreshing, setIsRefreshing, postReissueToken and router.push so the flow sets
refreshStatus to "failed" once and prevents further automatic retries until an
explicit retry is triggered.
- refreshStatus가 'failed'일 때 재시도하지 않도록 가드 추가 - 토큰 재발급 실패 후 반복적인 리다이렉트 방지
관련 이슈
작업 내용
멘토 페이지 레이지로드 적용 (2fdbb7e)
멘토/멘티 페이지 분리 (a97e439)
rounded-lg 스타일 수정 (798d026)
특이 사항
리뷰 요구사항 (선택)