feat: use URL instead of path/params [breaking change]#5
Open
laggingreflex wants to merge 1 commit into
Open
Conversation
laggingreflex
force-pushed
the
feat/url
branch
from
October 29, 2018 11:51
d3e4c54 to
10c9674
Compare
This uses the native [URL](-like) object instead of separate path/params. [URL]: https://developer.mozilla.org/en-US/docs/Web/API/URL
laggingreflex
force-pushed
the
feat/url
branch
from
October 30, 2018 01:15
10c9674 to
639d382
Compare
Owner
|
Sorry, I totally missed this one. I will try to review ASAP. |
Owner
|
Thanks for the PR, interesting idea for sure.
Doesn't this work out of the box? If the searchParams.set/append are written in JS and not native code it should work, otherwise it won't. I don't know which is the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix #3, and fix #4. What do you think of this approach?
Instead of
patharray and separateparams, this uses a URL(-like) object (only thing different is it has a.paramsplain-object instead of searchParams)SearchParams to
paramsfeels like a hack, my original intention was to makesearchParamsworks just like it does on URL natively, but couldn't figure out how to trigger theobserve/syncUrlfunction onsearchParams.set/appendmethods. Might give it a shot later