Merged
Conversation
kfriedberger
previously approved these changes
Sep 12, 2025
Member
kfriedberger
left a comment
There was a problem hiding this comment.
The implementation looks good at first view.
Does it work with existing Yices2 bindings or do we need an update?
I saw the other PR. I am just wondering, whether we can merge this first.
Contributor
Author
Hello Karlheinz, |
Contributor
Author
|
Thanks for merging! I think we still need to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
in this PR we add support for arrays to the Yices2 backend. Yices has supported arrays for a while, however, the implementation is a bit non-standard. Instead of the usual array operations from SMTLIB we have to use function terms:
Constbecome(lambda (x::T) c)whereTis the index type andcthe default elementSelectbecomes regular function applicationStorebecome function update where we "fix" the function for a single valueArray types from SMTLIB then map to (curried) function types in Yices2
There can be some confusion between UF terms and arrays as both are just function terms in Yices2. We work around issue this by explicitly keeping track of all our UF declarations in the
FormulaCreatorand assume all other function terms must be arrays