Open
Conversation
modified: airtime_mvc/application/controllers/PreferenceController.php modified: airtime_mvc/application/forms/Preferences.php modified: airtime_mvc/application/models/Preference.php modified: airtime_mvc/application/models/StoredFile.php modified: airtime_mvc/application/views/scripts/form/preferences.phtml modified: airtime_mvc/public/js/airtime/preferences/preferences.js modified: airtime_mvc/public/js/airtime/preferences/support-setting.js airtime_mvc/application/forms/MixcloudPreferences.php airtime_mvc/application/models/Mixcloud.php airtime_mvc/application/views/scripts/form/preferences_mixcloud.phtml utils/mixcloud-uploader utils/mixcloud-uploader.php
new file: airtime_mvc/application/models/Mixcloud.php new file: airtime_mvc/application/views/scripts/form/preferences_mixcloud.phtml new file: utils/mixcloud-uploader new file: utils/mixcloud-uploader.php
* Hide Mixcloud prefs unless you have client_id and client_secret setup in your airtime.conf * Add the [mixcloud] section to default airtime.conf
ghost
assigned
* Added better resilience to a missing [mixcloud] section in airtime.conf, will make upgrades simpler.
|
Any plans of merging this soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch completes a basic (but usable) implementation of Mixcloud integration, with:
There's a few spots that leave a lot to be desired:
Ultimately, the SoundCloud/Mixcloud features need to be refactored into a common base including some sort of general upload manager, but for now, this will have to do. (We're out of time...)