scope: add RawVal type for raw float64 values#59
Merged
egonelbre merged 1 commit intospacemonkeygo:masterfrom May 20, 2025
Merged
scope: add RawVal type for raw float64 values#59egonelbre merged 1 commit intospacemonkeygo:masterfrom
egonelbre merged 1 commit intospacemonkeygo:masterfrom
Conversation
egonelbre
reviewed
May 15, 2025
egonelbre
reviewed
May 15, 2025
Member
|
if we only need the most recent value, can the thing being monitored be a StatSource instead? |
Contributor
Author
StatSource is harder to use, I would prefer to provide the simplicity of the Scope, but with limited number of aggregations. |
Adds a new RawVal type to store raw float64 values without any aggregation (histogram, sum, etc). This provides a simpler alternative to FloatVal when only the most recent value is needed. With high cardinality data, it's important to use only minimal fields (especially as Prometheus/Victoria can calculate the sum/min/max aggregations)
egonelbre
approved these changes
May 19, 2025
zeebo
reviewed
May 20, 2025
zeebo
reviewed
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new RawVal type to store raw float64 values without any aggregation (histogram, sum, etc).
This provides a simpler alternative to FloatVal when only the most recent value is needed.
With high cardinality data, it's important to use only minimal fields (especially as Prometheus/Victoria can calculate the sum/min/max aggregations)