Conversation
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
| c.updateParentsPflags() | ||
| c.Flags().AddFlagSet(c.PersistentFlags()) | ||
| c.Flags().AddFlagSet(c.parentsPflags) | ||
| c.Flags().AddParentFlagSet(c.parentsPflags) |
There was a problem hiding this comment.
Needs unit testing.
Also, not sure whether changing the default behavior is allowed. Probably this should be configurable.
jpmcb
left a comment
There was a problem hiding this comment.
Can you give a broader description of this change and what use case it's trying to solve?
Also, I'm assuming this is a subset of this PR? spf13/pflag#357 We would need to wait for a new pflag release and then consume it from the upstream.
|
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
|
|
As we have very few maintainers, and those have very little time, we've decided to remove the auto-close configuration. |
|
|
support pFlag
AddParentFlagSet(spf13/pflag#357)Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com