This repository was archived by the owner on Dec 20, 2019. It is now read-only.
Fixes connection error handling#30
Open
jamuus wants to merge 2 commits into
Open
Conversation
Contributor
|
You are correct, the port should not be open instantly, but wait for sphero.js to open it. Could you pls fix the tests failing so we can merge this? |
Author
|
I'll fix the tests and cleanup these commits when I get a chance to learn how Mocha works. |
Contributor
|
Have fixed the linting but don't know what I'm doing with tests aha |
Author
|
I've removed the irrelevant commits. |
Contributor
|
Thanks @jamuus I think it just needs the change I mentioned here #57 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when initialising serial port, it was defaulting to open immediately, which was using its own callback that emitted an error when there was one. serialport.js looks like it was trying to give a callback of its own but the open event never passes a value.
I have set serialport to not open immediately, and corrected the open line such that an error will be passed to the callback. Then I added error handling to the sphero connect function such that an error is passed to whatever calls connect.
This now means that connect's callback isn't only called on a successful connection. This could be avoided by properly catching and emitting the error events such that a orb.on('error'... will catch them.