This repository was archived by the owner on Dec 20, 2019. It is now read-only.
Handle error when the connecttion to the sphero fail#58
Open
GuillaumeRahbari wants to merge 1 commit into
Open
Handle error when the connecttion to the sphero fail#58GuillaumeRahbari wants to merge 1 commit into
GuillaumeRahbari wants to merge 1 commit into
Conversation
Contributor
|
Hi, @GuillaumeRahbari can you please look at your failing test? https://travis-ci.org/orbotix/sphero.js/jobs/102923952#L1248 Thank you! |
Contributor
|
Hi, @GuillaumeRahbari did you ever have a chance to look into the failing test on this PR? |
Author
|
No I'm sorry, I will take a look as soon as I can. I can't just right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before that, when we did "orb.connect()", if it failed it throws an error that we could not handle.
Now we are able to do "orb.on("error", function() { // Do something });". We can handle the error.