This repository was archived by the owner on Dec 20, 2019. It is now read-only.
Refactored serialport adaptor to work with latest version of serialport#99
Open
charliegerard wants to merge 2 commits into
Open
Refactored serialport adaptor to work with latest version of serialport#99charliegerard wants to merge 2 commits into
charliegerard wants to merge 2 commits into
Conversation
|
The issue here seems to be that Is there a reason as to why it's not in the package as a dependency? Anywho, thanks for the fix! |
|
Just stumbled upon this issue. You might wanna use this PR to fix this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest version of node-serialport, doing
require('serialport').SerialPortis deprecated so Sphero.js does not work anymore.Instead, serialport should be required with only
require('serialport')so I simply refactored the serialport.js file and it seems to be working fine now.