Skip to content
This repository was archived by the owner on Dec 20, 2019. It is now read-only.

Refactored serialport adaptor to work with latest version of serialport#99

Open
charliegerard wants to merge 2 commits into
sphero-inc:masterfrom
charliegerard:master
Open

Refactored serialport adaptor to work with latest version of serialport#99
charliegerard wants to merge 2 commits into
sphero-inc:masterfrom
charliegerard:master

Conversation

@charliegerard

Copy link
Copy Markdown

In the latest version of node-serialport, doing require('serialport').SerialPort is deprecated so Sphero.js does not work anymore.
Instead, serialport should be required with only require('serialport') so I simply refactored the serialport.js file and it seems to be working fine now.

@mefellows

Copy link
Copy Markdown

The issue here seems to be that serialport is not declared as a dependency in the package, but is installed only in the travis build. It works for you @charliegerard because, presumably, you've installed a later version locally.

Is there a reason as to why it's not in the package as a dependency?

Anywho, thanks for the fix!

@dariobraun

Copy link
Copy Markdown

Just stumbled upon this issue. You might wanna use this PR to fix this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants