-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Use uv native interface to simplify CI
#14149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
danieleades
wants to merge
13
commits into
sphinx-doc:master
Choose a base branch
from
danieleades:uv.ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−258
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e6a9bc6
chore: recommend UV for local development
91230c8
fixup
643070f
chore(ci): use uv native interface to simplify CI
b5c4e83
fixup
adbe4b4
fixup
cb4fa87
fixup
5714eb6
fixup
69ab3cb
fixup
4c6bf02
fixup
6718c13
fixup
8440054
fixup
c56090d
Merge branch 'master' into uv.ci
AA-Turner 9401a84
post-merge fixup
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,6 @@ concurrency: | |
|
|
||
| env: | ||
| FORCE_COLOR: "1" | ||
| UV_SYSTEM_PYTHON: "1" # make uv do global installs | ||
|
|
||
| jobs: | ||
| verbose: | ||
|
|
@@ -30,18 +29,6 @@ jobs: | |
| python-version: "3" | ||
| - name: Install graphviz | ||
| run: sudo apt-get install --no-install-recommends --yes graphviz | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| version: latest | ||
| enable-cache: false | ||
| - name: Install dependencies | ||
| run: uv pip install . --group docs | ||
| - uses: astral-sh/setup-uv@v7 | ||
| - name: Render the documentation | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a way we can keep the split of the resolve/install step and the run command step (throughout)? I use CI timings as a rough hueristic for various things. |
||
| run: > | ||
| sphinx-build | ||
| -M html ./doc ./build/sphinx | ||
| --verbose | ||
| --jobs=auto | ||
| --show-traceback | ||
| --fail-on-warning | ||
| run: uv run --locked --group docs sphinx-build -M html ./doc ./build/sphinx --verbose --jobs=auto --show-traceback --fail-on-warning | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to remove the name/options keys?