Repository navigation

fix: backport upstream fixes for wrong results from filter pushdown, dynamic filters, simplification and planning - #235

Merged

lukekim merged 27 commits into

spiceai-54from

lukim/spiceai-54-wrong-results-backports

Sep 27, 2026

Commits on Sep 26, 2026
- fix: aggregate dynamic filtering with unsupported expressions (#24817)
  
  lyne7-sc
  authored and
  lukekim
  committed
  b028809
- fix: preserve aggregate filter pushdown order (#22926)
  
  discord9
  authored and
  lukekim
  committed
  67535bb
- fix: prevent incorrect results when pushing filters through anti joins (#24045)
  
  buraksenn
  authored and
  lukekim
  committed
  4ea30ba
- perf: skip building FilterRemapper when there are no parent filters (#24428)
  
  authored and
  lukekim
  committed
  d78f261
- fix: map pushed-down filter columns by position instead of by name (#25259)
  
  haohuaijin
  authored and
  lukekim
  committed
  5c24978
- fix: keep null-aware anti-join NULLs in the pushed dynamic filter (#23104)
  
  mdashti
  authored and
  lukekim
  committed
  6205fda
- fix: skip dynamic filter pushdown for null-aware anti joins with a nullable build key (#23173)
  
  mdashti
  authored and
  lukekim
  committed
  c23a61b
- test: drop an aggregates test import that 54.1 does not use
  lukekim
  committed
  85400b6
- fix: Disable join dynamic filters for null-equal joins (#22965)
  
  neilconway
  authored and
  lukekim
  committed
  0444d4d
- fix: re-enable null-equal join dynamic filters with an IS NULL predicate (#23106)
  
  mdashti
  authored and
  lukekim
  committed
  30538e6
- fix: NOT IN with NULL subquery returns wrong results under SortMergeJoin (#22810)
  
  nathanb9
  authored and
  lukekim
  committed
  67c2051
- fix: TopK aggregation drops groups whose MIN/MAX value is NULL (#23684)
  
  u70b3
  authored and
  lukekim
  committed
  f6222e3
- fix: preserve NULL semantics in `log` and `power` simplification (#24247)
  
  lyne7-sc
  authored and
  lukekim
  committed
  31012b5
- fix: preserve NULL semantics in bitwise xor simplification (#24248)
  
  lyne7-sc
  authored and
  lukekim
  committed
  bb82ff0
- fix: preserve NULL semantics when simplifying col ~ '.*' (#24380)
  
  viirya
  authored and
  lukekim
  committed
  53e60cd
- fix: preserve nested projection expressions (#24686)
  
  discord9
  authored and
  lukekim
  committed
  cbc04dd
- fix: sort pushed below `GlobalLimitExec` ignores `skip`, returning too few rows (#24958)
  
  jayzhan211
  authored and
  lukekim
  committed
  5a0f295
- fix: prevent panic and incorrect results for COUNT with ORDER BY (#24997)
  
  geoffreyclaude
  authored and
  lukekim
  committed
  42d3888
- fix: `NOT IN (subquery)` with a constant value ignores NULLs in the subquery (#25348)
  
  adriangb
  authored and
  lukekim
  committed
  cc926a0
- fix: only propagate cast statistics through safe conversions (#25227)
  
  haohuaijin
  authored and
  lukekim
  committed
  794e282
- test: drop the single-pass collapse assertion from merge_deep_projection_chain_in_one_pass
  lukekim
  committed
  fdfaec8
- test: use a NOT NULL table for the non-nullable log/power bases plan
  lukekim
  committed
  70834cd
- test: expect the NOT IN plan without the null_aware display marker
  lukekim
  committed
  5ac6b8e
Commits on Sep 27, 2026
- fix: plan a correlated `NOT IN (subquery)` as the `NOT EXISTS` it equals in a filter
  lukekim
  committed
  76c676a
- test: render the #22810 NOT IN plan with the fork's HashJoinExec accumulator display
  lukekim
  committed
  1ef0eee
- fix: Fix nullability of logical `InSubquery` expression (#23429)
  
  AdamGS
  authored and
  lukekim
  committed
  624470f
- fix: account for empty scalar subqueries in nullability (#24516)
  
  fornwall
  authored and
  lukekim
  committed
  d1815c2

Navigation Menu

Repository navigation

fix: backport upstream fixes for wrong results from filter pushdown, dynamic filters, simplification and planning - #235

fix: backport upstream fixes for wrong results from filter pushdown, dynamic filters, simplification and planning#235
lukekim merged 27 commits into
spiceai-54from
lukim/spiceai-54-wrong-results-backports

Commits on Sep 26, 2026

fix: aggregate dynamic filtering with unsupported expressions (#24817)

fix: preserve aggregate filter pushdown order (#22926)

fix: prevent incorrect results when pushing filters through anti joins (#24045)

perf: skip building FilterRemapper when there are no parent filters (#24428)

fix: map pushed-down filter columns by position instead of by name (#25259)

fix: keep null-aware anti-join NULLs in the pushed dynamic filter (#23104)

fix: skip dynamic filter pushdown for null-aware anti joins with a nullable build key (#23173)

test: drop an aggregates test import that 54.1 does not use

fix: Disable join dynamic filters for null-equal joins (#22965)

fix: re-enable null-equal join dynamic filters with an IS NULL predicate (#23106)

fix: NOT IN with NULL subquery returns wrong results under SortMergeJoin (#22810)

fix: TopK aggregation drops groups whose MIN/MAX value is NULL (#23684)

fix: preserve NULL semantics in `log` and `power` simplification (#24247)

fix: preserve NULL semantics in bitwise xor simplification (#24248)

fix: preserve NULL semantics when simplifying col ~ '.*' (#24380)

fix: preserve nested projection expressions (#24686)

fix: sort pushed below `GlobalLimitExec` ignores `skip`, returning too few rows (#24958)

fix: prevent panic and incorrect results for COUNT with ORDER BY (#24997)

fix: `NOT IN (subquery)` with a constant value ignores NULLs in the subquery (#25348)

fix: only propagate cast statistics through safe conversions (#25227)

test: drop the single-pass collapse assertion from merge_deep_projection_chain_in_one_pass

test: use a NOT NULL table for the non-nullable log/power bases plan

test: expect the NOT IN plan without the null_aware display marker

Commits on Sep 27, 2026

fix: plan a correlated `NOT IN (subquery)` as the `NOT EXISTS` it equals in a filter

test: render the #22810 NOT IN plan with the fork's HashJoinExec accumulator display

fix: Fix nullability of logical `InSubquery` expression (#23429)

fix: account for empty scalar subqueries in nullability (#24516)