Repository navigation
docs(cayenne): v2.2 preserves timestamp units; the 2.2.x snapshot still says microseconds - #2189
Merged
Merged
Conversation
…ll said microseconds spiceai/spiceai#13180 removed TimestampToMicrosecond from Cayenne's creation rewrite rules, so a table created on v2.2.0 or v2.2.1 keeps its source unit and timezone. The version-2.2.x snapshot still listed timestamps as normalized to microseconds and carried the Timestamp(Nanosecond) -> Timestamp(Microsecond) conversion row. Mirrors the vNext wording from #2186 into the snapshot the change actually shipped in. version-2.1.x and earlier are left alone: those releases really do normalize unconditionally.
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://a4c903d8.spiceai-org-website.pages.dev |
lukekim
approved these changes
Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
version-2.2.xCayenne page still documents unconditional timestamp normalization:Timestamp(Nanosecond/...)→Timestamp(Microsecond)row, "Precision normalized"Cayenne stopped doing that in v2.2.0. spiceai/spiceai#13180 split the rewrite lists in two and dropped
TimestampToMicrosecondfrom the creation rules:TimestampToMicrosecondsurvives only in the write-path recognition list, so an existing microsecond table fed by a nanosecond source is not misread as a schema change — it is not applied when creating a table. A table created on v2.2.0 or v2.2.1 keeps its source unit and timezone.This is the "current-release behavioral change lands only in
website/docs/" case: #2186 fixed vNext and left the snapshot the change shipped in stale.Version scoping
At v2.1.5
schema.rsstill has the unconditional arm, which is why the older snapshots are right as they stand:What changed
website/versioned_docs/version-2.2.x/components/data-accelerators/cayenne/index.mdonly — the two claims above, replaced with the vNext wording, including the "Tables created before v2.2.0" note (the boundary is correct for this snapshot as written, since the change shipped in v2.2.0).mode: file_createis a real mode at v2.2.1.Source refs
git tag --contains→v2.2.0,v2.2.1crates/cayenne/src/schema.rsat v2.2.1 — the split rewrite listscrates/cayenne/src/schema.rsat v2.1.5 — the unconditional normalization the older snapshots documentTest plan
cd website && npm run buildpasses (#on_schema_changeexists in the 2.2.xdatasets.md)grep -rln "normalized to Microsecond" website/now returns only 2.1.x, 2.0.x and 1.11.x, all correct