Repository navigation
docs(caching): the pingora cache engine is Enterprise-only in v2.3.0 too - #2204
Merged
Merged
Conversation
The version-2.3.x snapshot was cut hours before #2188, so the newest release's caching page still presents `engine: pingora` as an ordinary open source backend. On a stock spiced the value parses, the runtime warns and runs Moka instead.
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://8510bfba.spiceai-org-website.pages.dev |
lukekim
approved these changes
Sep 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
version-2.3.xsnapshot was published on 2026-09-10 at 11:24 UTC; #2188 merged at 15:07 the same day and editedwebsite/docs/only. So the newest release's caching page still presentsengine: pingoraas an ordinary open source backend, and describes its sharded-LRU behaviour as what a reader who sets it will get.On a published open source
spicedthey will not get it.pingorais absent frombin/spiced'sdefaultfeature list, theCacheEngineenum is not feature-gated (so the value parses and nothing fails), and the dispatch arm warns and builds a Moka backend instead. This is the edition-gating shape the hygiene reference calls out: a config enum declared inspicepodbut implemented behind a cargo feature.This applies #2188's text to the 2.3.x snapshot; the page is now byte-identical to trunk's vNext copy.
Scope: only
version-2.3.x.features/caching/index.mdin 2.0.x, 2.1.x and 2.2.x does not mentionengine/pingoraat all.Source PRs
Test plan
cd website && npm run build:diff -u website/versioned_docs/version-2.3.x/features/caching/index.md website/docs/features/caching/index.mdnow prints nothing: the snapshot matches vNext exactly.grep -rln 'pingora' website/docs website/versioned_docsreturns only the two caching pages plus theacknowledgements/index.mddependency lists; no other page carries the claim.versioned_docs/version-2.3.x/features/caching/index.md, matching the diff.Reproduction
Doc said (
website/versioned_docs/version-2.3.x/features/caching/index.md:54at docsc0f47f88):Code says —
pingorais not in the default feature set at v2.3.0:and the non-
pingorabuild arm falls back (crates/cache/src/lru_cache.rsat v2.3.0):Every string the page quotes is grepped from v2.3.0 source, not paraphrased:
The startup line the page tells readers to check is the
Displayimpl atlru_cache.rs:208("max size: {:.2}, item ttl: {:?}, engine: {}") interpolated intotracing::info!("Initialized sql results cache; {cache_provider}")atcrates/runtime/src/init/caching.rs:54, andCacheBackendEnum::MokaFallback(_) => CacheEngine::Mokaatlru_cache.rs:177is why it readsMokarather than the configured value.Behavior claim: not run — reproducing the fallback warning needs a
spicedbuilt at the v2.3.0 tag with the default feature set. The correction rests on the feature-list grep and the#[cfg(not(feature = "pingora"))]arm quoted above, so it is labeled Unverified, code inspection only for the runtime behaviour and Reproduced for the edition-gating claim itself.