Repository navigation
docs(cli): v2.3.0 spice version always names the runtime path - #2206
Merged
Merged
Conversation
The version-2.3.x snapshot was cut hours before #2190, so it still ties the Runtime path line to a runtime outside the managed install. At v2.3.0 spice version prints it whenever a runtime resolves, with no test on the source; the conditional is real but belongs to spice run, where it is a log level, not presence.
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
|
🚀 deployed to https://3870beab.spiceai-org-website.pages.dev |
lukekim
approved these changes
Sep 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-2.3.xwas cut on 2026-09-10 at 11:24 UTC; #2190 merged at 15:07 the same day and editedwebsite/docs/only. So the newest release's CLI reference still says theRuntime pathline appears only "for a runtime outside the managed install".At v2.3.0
spice versionprints it whenever a runtime resolves, with no test on the source — a reader on an ordinaryspice installwho sees the line has no reason to think anything unusual has happened, and a reader who doesn't see it has been told the wrong reason why. The conditional in the sentence is real, but it belongs tospice run, where it is a log level (infovsdebug), not presence.This applies #2190's text to the 2.3.x snapshot; both pages are now byte-identical to trunk's vNext copies. Every sentence in the swept text was re-verified against v2.3.0 rather than assumed to carry over — the four source strings, the
--cli-onlybranch, the unprobeable-runtime wording and the JSON shape are quoted below.Scope: only
version-2.3.x—grep -rn "For a runtime outside the managed install" website/now returns nothing anywhere, and no older snapshot ever carried the sentence (it arrived with #2186).Source PRs
Test plan
cd website && npm run build:diff -q website/versioned_docs/version-2.3.x/cli/reference/{run,version}.md website/docs/cli/reference/{run,version}.mdreports both pairs identical, andgrep -rn "For a runtime outside the managed install" website/returns nothing.[spice install](./install)target exists (ls website/versioned_docs/version-2.3.x/cli/reference/install.md), and the./run#runtime-selectionanchor resolves to the### Runtime selectionheading in the same snapshot'srun.md; the full build above is the authoritative gate on both.versioned_docs/version-2.3.x/cli/reference/version.mdand.../run.md, matching the diff.Reproduction
Doc said (
website/versioned_docs/version-2.3.x/cli/reference/version.md:46at docsc0f47f88):Code says (
bin/spice/src/commands/version.rsat v2.3.0) — the only guards are--cli-onlyand "a runtime resolved at all":The conditional the sentence describes is in
spice run, and it is a level, not presence (bin/spice/src/runtime_launcher.rs:126-132at v2.3.0):Each remaining string in the replacement text is grepped from v2.3.0, not paraphrased:
version.rs:247givesNone => "not installed"and:250the"unavailable — the runtime at the path below did not report a version"wording; the JSON arm at:218-229mapsruntime_path/runtime_sourcethroughresolved.as_ref().map(...)— hencenullwhen nothing resolves — and serialisesfound.source, the enum, rather thandescribe().Behavior claim: not run — reproducing the printed output needs a
spiceCLI built at the v2.3.0 tag. The correction is an existence claim about a guard (if let Some(resolved)with no source test) plus four string literals, settled by the quoted lines, so it is labeled Reproduced on that basis.