Repository navigation
launch: make the three-source, bring-your-own-key scenario a one-shot - #31
Closed
vladisemenov wants to merge 1 commit into
Closed
vladisemenov wants to merge 1 commit into
vladisemenov wants to merge 1 commit into
Conversation
Fixes and additions found by running the skill end to end on a Snowflake, Databricks, and Postgres scenario with stand-in data and pending LLM keys. - local: wait for /v1/ready instead of stopping when the datasets settle. Views are not listed by the runtime and a join over a 1.5M-row table took about 32 s, so the old check reported "did not become ready locally" for a spicepod that was healthy. It still stops early when a component errors. - preflight: the credential hint now covers the case where `spice cloud login` succeeded but the helper finds no credential: a personal access token in .env.local, entered in an editor, not pasted into a command. - SKILL.md: ask every missing question in one message, including the Cloud credential; interpret "users bring their own LLM key" explicitly (hosted models versus a client-side LLM over MCP; Spice has no per-request key); keep a model out of the spicepod until its key is stored; put the project directory outside any Git checkout; add a teammate-sharing note (Spice.ai username not email, org-wide access, confirm the role); two new Don'ts. - scenarios.md: Databricks connector section checked against the connector docs, multi-provider model guidance (Anthropic and xAI are Alpha), and the TPC-H layout that gives Snowflake, Databricks, and Postgres each a role. - examples/spicepod.unified-data.yaml: that layout, validated with and without the model blocks, deployed and verified on Spice.ai Cloud. - evals: add the scenario as eval 4. make check, test-distribution, and release-preview pass.
Author
|
@lukekim please review I have read only permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and additions from running the
launchskill end to end on a Snowflake, Databricks, and Postgres scenario, with stand-in data and LLM keys that did not exist yet. The scenario deployed and verified on Spice.ai Cloud (v2.3.2): 12/12 checks, five datasets and two cross-source views returning rows, an MCP session with 8sqlcalls and nosession_not_found, p50 555 ms and p99 636 ms over 50 uncached queries.Changes
localno longer reports a healthy spicepod as not ready. It stopped when the datasets settled, about 15 s in, but views are not listed by the runtime and a join over a 1.5M-row table took about 32 s to initialize. It now waits for/v1/readyand still stops early when a component reportsError."ok": false, "ready": false, "error": "the spicepod did not become ready locally"."ok": true, "ready": true./v1/readyafter about 32 s and returned 150,000 rows fromcustomer_ordersand 25 fromcountry_overview.spice cloud loginreported success,preflightstill returnedmanagement_token_missing. The hint and Step 3 now give the path that worked: a personal access token in.env.local, entered in an editor and not pasted into a command (a silentread -sprompt took no input in an embedded terminal). They also tell the agent not to search for the credential itself.examples/spicepod.unified-data.yaml. That layout, with the Claude, OpenAI, and Grok blocks commented out.spice validatepasses with the models commented and uncommented (3 models), and the same layout was deployed and verified as above.Verification
make check test-distribution release-previewpasses (13 tests, 17 skills, no problems).SKILL.mdis 372 lines (cap 500); the skilldescriptionis unchanged.Not included