Feature/ble coredumps#83
Open
jmasek wants to merge 4 commits into
Open
Conversation
roberthusak
reviewed
Jun 26, 2026
| AGENTS.md | ||
| CLAUDE.md | ||
| **/sdkconfig.local | ||
| **/build-rw612 |
Collaborator
There was a problem hiding this comment.
Nitpick: I suggest removing this line and using paths like <sample>/build/<board> for development instead.
roberthusak
reviewed
Jun 26, 2026
| feature == SPOTFLOW_TRANSPORT_FEATURE_CONFIG || | ||
| feature == SPOTFLOW_TRANSPORT_FEATURE_METRICS; | ||
| feature == SPOTFLOW_TRANSPORT_FEATURE_METRICS || | ||
| feature == SPOTFLOW_TRANSPORT_FEATURE_COREDUMPS; |
Collaborator
There was a problem hiding this comment.
Since it always returns true, can we now remove this function completely, then? When adding OTA updates, we can check in build time that MQTT is used with them.
roberthusak
reviewed
Jun 26, 2026
Comment on lines
+36
to
+40
| static void button_pressed(void) | ||
| { | ||
| LOG_INF("Button pressed. Going to oops."); | ||
| k_oops(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I suggest moving the button polling/callback-handling logic to another file and keeping just this function here. Even polling can be done in a separate thread so that the main logging loop can stay simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.