test: add spec test for duplicate variant materialization assignments#345
test: add spec test for duplicate variant materialization assignments#345
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yyoyoian-pixel
left a comment
There was a problem hiding this comment.
LGTM — targets a real and subtle edge case (two assignments for the same variant in different bucket ranges). The new assignment_id assertion infrastructure via resolve token decryption is a useful addition to the spec test framework.
Optional suggestion: a complementary test with a different targeting_key that hashes into the 0-500 range (expecting a1) would fully exercise both assignments and guard against boundary bugs.
vahidlazio
left a comment
There was a problem hiding this comment.
LGTM — targets a real and subtle edge case (two assignments for the same variant in different bucket ranges). The new assignment_id assertion infrastructure via resolve token decryption is a useful addition to the spec test framework.
Optional suggestion: a complementary test with a different targeting_key that hashes into the 0-500 range (expecting a1) would fully exercise both assignments and guard against boundary bugs.
Summary
Test plan
cargo test -p confidence_resolver mat_same_variantpasses🤖 Generated with Claude Code