feat: pass Array to flag evaluation - #203
Merged
Merged
Conversation
fabriziodemaria
requested review from
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
June 26, 2025 14:13
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
eval-structs
branch
from
June 26, 2025 14:29
4179a7a to
0e7dabd
Compare
fabriziodemaria
force-pushed
the
eval-lists
branch
from
June 26, 2025 14:34
dc1254f to
35f26ae
Compare
vahidlazio
previously approved these changes
Jun 27, 2025
fabriziodemaria
dismissed
vahidlazio’s stale review
June 27, 2025 13:47
The base branch was changed.
fabriziodemaria
force-pushed
the
eval-lists
branch
from
June 27, 2025 13:50
35f26ae to
df60404
Compare
vahidlazio
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Natural evolution of #193, split into a separate PR for easier review.
Behaviour
The list types must match otherwise the default value is returned