feat!: fix: Restore ConfidenceStruct evals, align Dictionary evals - #205
Merged
Conversation
fabriziodemaria
requested review from
mfranberg,
nicklasl,
nickybondarenko and
vahidlazio
as code owners
June 27, 2025 15:13
fabriziodemaria
force-pushed
the
eval-confidencestruct
branch
2 times, most recently
from
June 27, 2025 15:24
c87a7c3 to
05ce929
Compare
vahidlazio
previously approved these changes
Jun 27, 2025
fabriziodemaria
force-pushed
the
eval-confidencestruct
branch
from
June 27, 2025 16:01
0de932e to
ae4e9bb
Compare
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
eval-confidencestruct
branch
7 times, most recently
from
June 30, 2025 11:54
bfdf314 to
b8d882f
Compare
fabriziodemaria
force-pushed
the
eval-confidencestruct
branch
from
June 30, 2025 12:29
3f3dd6e to
b305208
Compare
fabriziodemaria
force-pushed
the
eval-confidencestruct
branch
from
June 30, 2025 12:45
b305208 to
71e1579
Compare
vahidlazio
approved these changes
Jun 30, 2025
vahidlazio
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
ConfidenceStructas default value for complex evaluations. This PR restores that capability.nullentries in the remote variant: the default value for those entries is used, rather than null. This also aligns with the new behavior from the Dictionary-based evaluations. This is a backwards incompatible change, despite probably minor